fix: update gzip types and remove IE6 workaround in nginx config#40681
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
fix: update gzip types and remove IE6 workaround in nginx config#40681lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
engcom-Dash
added
the
Priority: P4
Contributor
|
@magento create issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expand the
gzip_typeslist with missing compressible content types and remove the obsoletegzip_disable "msie6"directive fromnginx.conf.sample.Changes
1. Add missing gzip types
Add three compressible content types that are commonly served by Magento but not currently compressed:
application/manifest+jsonapplication/vnd.ms-fontobjectfont/opentypeNote: WOFF and WOFF2 fonts are already internally compressed and should not be gzip-compressed (double compression increases size).
2. Remove
gzip_disable "msie6"This directive disabled gzip for Internet Explorer 6, which had a broken gzip implementation. IE6 was released in 2001 and has had effectively zero market share for over a decade. The directive is dead weight.
Files Changed
nginx.conf.sample⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz
Resolved issues: